Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acceptance test for Clique when configured to not create empty blocks #6191

Merged
merged 3 commits into from
Nov 23, 2023

Conversation

fab-10
Copy link
Contributor

@fab-10 fab-10 commented Nov 21, 2023

PR description

Fixed Issue(s)

Copy link

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I thought about the changelog and included a changelog update if required.
  • If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests

@fab-10 fab-10 enabled auto-merge (squash) November 21, 2023 11:37
Copy link
Contributor

@Gabriel-Trintinalia Gabriel-Trintinalia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

jframe
jframe previously approved these changes Nov 21, 2023
Copy link
Contributor

@jframe jframe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jframe jframe dismissed their stale review November 21, 2023 22:50

add more comments

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
@fab-10 fab-10 force-pushed the clique-no-empty-blocks-at branch 2 times, most recently from 3669fed to 98037f1 Compare November 22, 2023 10:49
@fab-10 fab-10 disabled auto-merge November 22, 2023 10:57
@fab-10 fab-10 force-pushed the clique-no-empty-blocks-at branch 2 times, most recently from d13d8db to 8c2204e Compare November 22, 2023 18:13
…blocks is false

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Copy link
Contributor

@jframe jframe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fab-10 fab-10 enabled auto-merge (squash) November 23, 2023 08:58
@fab-10 fab-10 merged commit be5cc68 into hyperledger:main Nov 23, 2023
18 checks passed
@fab-10 fab-10 deleted the clique-no-empty-blocks-at branch November 23, 2023 09:39
jflo pushed a commit to jflo/besu that referenced this pull request Dec 4, 2023
…hyperledger#6191)

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
jflo pushed a commit to jflo/besu that referenced this pull request Dec 4, 2023
jflo pushed a commit to jflo/besu that referenced this pull request Dec 4, 2023
…hyperledger#6191)

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
gfukushima pushed a commit to gfukushima/besu that referenced this pull request Dec 15, 2023
…hyperledger#6191)

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants